Add Windows subsection to the installation section of the Envoy docs#15699
Add Windows subsection to the installation section of the Envoy docs#15699mattklein123 merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Randy Miller <rmiller14@gmail.com>
|
rendered docs are here: https://storage.googleapis.com/envoy-pr/15699/docs/index.html |
|
im wondering if there is a non "dev" image for windows. im aware that the current instructions for linux-based image is using the "latest" dev image but i think that was a mistake on my part - i opened a ticket here to deal with it #15730 |
|
The first non-dev image should occur with the 1.18.0 tag, the logic wasn't in place with 1.17.x branch... IIUC, @sunjayBhatia or @lizan can you confirm? |
|
Yeah this image should be pushed with the 1.18.0 release: https://hub.docker.com/r/envoyproxy/envoy-windows (the repo wasn't created yet for the 1.17.x line yet) |
|
not sure which way round to deal with this, i can fix the issue above and then you can adjust this PR to add it - or alternately you could land this and ill move it to the dev section |
|
I already created the repo but it won't have any image before 1.18.0. |
|
Can we make an issue to track updating this documentation once the windows release image has been published? I think this PR is good enough for anyone who wants to get a hold of an envoy binary today, right? |
|
i think the issue is that the existing docs are showing the dev image "as if" they were production images - which is wrong - and this risks making the problem worse |
phlax
left a comment
There was a problem hiding this comment.
@rmiller14 thanks for this
i think best land this - and we can resolve the issue/s with dev/production images separately - the underlying issue is unrelated to this PR
|
@lizan @mattklein123 can we get this merged please? |
Commit Message:
Add Windows subsection to the installation section of the Envoy docs.
Risk Level: Low
Testing: Built the documentation.
Docs Changes: The installation section of the Envoy docs is missing Windows-specific instructions. This PR adds a subsection for installing on Windows, which today only includes using the envoy-windows-dev Docker image.
Addresses #14605.