[Windows] Improve SCM error logging#15638
Conversation
Signed-off-by: davinci26 <sotirisnan@gmail.com>
|
@wrowe PTAL |
Signed-off-by: davinci26 <sotirisnan@gmail.com>
Signed-off-by: davinci26 <sotirisnan@gmail.com>
Signed-off-by: davinci26 <sotirisnan@gmail.com>
Signed-off-by: davinci26 <sotirisnan@gmail.com>
Signed-off-by: davinci26 <sotirisnan@gmail.com>
|
/retest |
|
Retrying Azure Pipelines: |
|
@wrowe lets get it merged before 1.18 since it is an already experimental feature. I look for your comments |
wrowe
left a comment
There was a problem hiding this comment.
This looks good to me, ready for a pass by @envoyproxy/senior-maintainers specific to logging architecture. Since this gets the error text of well-formed exceptions into the event log for troubleshooting, it's a good step forward.
mattklein123
left a comment
There was a problem hiding this comment.
Thanks LGTM with small comments.
/wait
|
@mattklein123 sorry for the delayed response, I was on PTO. Ack the comments and I will address them today |
Signed-off-by: davinci26 <sotirisnan@gmail.com>
|
/retest |
|
Retrying Azure Pipelines: |
|
Unrelated flake in coverage |
Signed-off-by: Sotiris Nanopoulos sonanopo@microsoft.com
Commit Message:
Envoy registers with SCM before it parses the command line and as a result we don't have access to loggers. Additionally SCM by default captures the stdout/stderr so we can't really write to the standard streams. As a result debugging startup failures in SCM is a bit tricky.
To solve this I used the
spdlog::sinks::win_eventlog_sink_mtwhich writes to the Windows Event Viewer. We use this logger directly for failures during SCM initialization.Additional Description: N/A
Risk Level: Low
Testing: Manual
Docs Changes: Done
Release Notes: N/A
Platform Specific Features: Windows Only