tls: enable allow_expired_certificate for SPIFFE validator#15426
Merged
mattklein123 merged 9 commits intoenvoyproxy:mainfrom Mar 19, 2021
Merged
tls: enable allow_expired_certificate for SPIFFE validator#15426mattklein123 merged 9 commits intoenvoyproxy:mainfrom
mattklein123 merged 9 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Member
|
cc. @envoyproxy/first-pass-reviewers |
asraa
reviewed
Mar 12, 2021
source/extensions/transport_sockets/tls/cert_validator/spiffe/spiffe_validator.cc
Outdated
Show resolved
Hide resolved
test/extensions/transport_sockets/tls/cert_validator/spiffe/spiffe_validator_test.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
asraa
approved these changes
Mar 15, 2021
Contributor
asraa
left a comment
There was a problem hiding this comment.
LGTM! @envoyproxy/senior-maintainers for final pass please
mattklein123
approved these changes
Mar 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: tls: enable allow_expired_certificate flag in ValidationContext for SPIFFE validator
Signed-off-by: Takeshi Yoneda takeshi@tetrate.io