Skip to content

access_log: Fix substition formatter to recognize commands containing integers#15256

Merged
zuercher merged 4 commits intoenvoyproxy:mainfrom
derekargueta:substition-formatter-fix
Mar 3, 2021
Merged

access_log: Fix substition formatter to recognize commands containing integers#15256
zuercher merged 4 commits intoenvoyproxy:mainfrom
derekargueta:substition-formatter-fix

Conversation

@derekargueta
Copy link
Copy Markdown
Member

Fixes #15255

Signed-off-by: Derek Argueta darguetap@gmail.com

@derekargueta derekargueta changed the title Fix substition formatter to recognize commands containing integers access_log: Fix substition formatter to recognize commands containing integers Mar 2, 2021
zuercher
zuercher previously approved these changes Mar 2, 2021
Signed-off-by: Derek Argueta <darguetap@gmail.com>
Signed-off-by: Derek Argueta <darguetap@gmail.com>
Signed-off-by: Derek Argueta <darguetap@gmail.com>
@derekargueta
Copy link
Copy Markdown
Member Author

gah messed up my git history when forgetting to sign, sorry for the force push

@derekargueta derekargueta force-pushed the substition-formatter-fix branch from 9c11db2 to 1f439c0 Compare March 2, 2021 21:18
Signed-off-by: Derek Argueta <darguetap@gmail.com>
@zuercher zuercher merged commit 671e436 into envoyproxy:main Mar 3, 2021
@derekargueta derekargueta deleted the substition-formatter-fix branch March 3, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Substition Formatter won't accept %DOWNSTREAM_PEER_FINGERPRINT_256% or %DOWNSTREAM_PEER_FINGERPRINT_1%

2 participants