wasm: remove non-representative and redundant benchmarks.#15203
Merged
lizan merged 1 commit intoenvoyproxy:mainfrom Mar 3, 2021
Merged
wasm: remove non-representative and redundant benchmarks.#15203lizan merged 1 commit intoenvoyproxy:mainfrom
lizan merged 1 commit intoenvoyproxy:mainfrom
Conversation
The "json_serialize_arena" test was non-representative, and it was running out of memory in WasmVM during benchmarks, leading to invalid results. The "json_deserialize_arena" test was measuring exactly the same process as the "json_deserialize" test, so it was redundant. The "json_serialize_deserialize" test was a combinantion of "json_serialize" and "json_deserialize" tests, so it was redundant. While there, make sure that inputs are not used as outputs, and vice-versa. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Contributor
Author
|
@mattklein123 it looks that @mathetake isn't auto-assigned to Wasm PRs, even though he is listed in |
Member
Sorry no idea. @mathetake is a member of the org and the assignable group. |
Member
|
I guess that's because I don't have write permission: https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners |
lizan
approved these changes
Mar 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "json_serialize_arena" test was non-representative, and it was running
out of memory in WasmVM during benchmarks, leading to invalid results.
The "json_deserialize_arena" test was measuring exactly the same process as
the "json_deserialize" test, so it was redundant.
The "json_serialize_deserialize" test was a combinantion of "json_serialize"
and "json_deserialize" tests, so it was redundant.
While there, make sure that inputs are not used as outputs, and vice-versa.
Signed-off-by: Piotr Sikora piotrsikora@google.com