Fix flaky test script's generated PR links#15063
Merged
lizan merged 2 commits intoenvoyproxy:mainfrom Feb 17, 2021
Merged
Conversation
Signed-off-by: Randy Miller <rmiller14@gmail.com>
Contributor
Author
|
There's a non-zero chance formatting fails. |
Contributor
Author
|
@davinci26 FYI. |
lizan
previously approved these changes
Feb 16, 2021
Signed-off-by: Randy Miller <rmiller14@gmail.com>
Contributor
Author
|
Formatting should be good now. |
lizan
approved these changes
Feb 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
The flaky test script currently generates a bogus PR link for test flakes. The problem is that the pull request ID is used in the link instead of the pull request number (see here for more info). This PR uses the correct predefined environment variable.
Signed-off-by: Randy Miller rmiller14@gmail.com
Risk Level: Low
Testing: Ran the script a few times with environment variable manually populated