http2: Latch envoy.reloadable_features.upstream_http2_flood_checks on connection creation.#15005
Merged
yanavlasov merged 1 commit intoenvoyproxy:mainfrom Mar 2, 2021
Merged
Conversation
… connection creation. Checking the runtime feature on every packet sent results in excessive lock contention and could trigger incorrect termination of HTTP2 upstream connections if the value of the runtime feature changes halfway through the lifetime of the upstream connection. Signed-off-by: Antonio Vicente <avd@google.com>
dmitri-d
approved these changes
Feb 10, 2021
Contributor
|
/retest |
|
Retrying Azure Pipelines: |
yanavlasov
approved these changes
Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
http2: Latch envoy.reloadable_features.upstream_http2_flood_checks on connection creation.
Checking the runtime feature on every packet sent results in excessive lock contention and
could trigger incorrect termination of HTTP2 upstream connections if the value of the runtime
feature changes halfway through the lifetime of the upstream connection.
Additional Description:
Risk Level: low, latching a runtime feature. minimal functional change expected.
Testing: covered by existing tests
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
Fixes #14996