lds: ASAN repro of heap-use-after-free in LDS and a single character fix#14896
Merged
ggreenway merged 3 commits intoenvoyproxy:mainfrom Feb 2, 2021
Merged
lds: ASAN repro of heap-use-after-free in LDS and a single character fix#14896ggreenway merged 3 commits intoenvoyproxy:mainfrom
ggreenway merged 3 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: pengg <pengg@google.com>
Signed-off-by: pengg <pengg@google.com>
Contributor
Author
lizan
previously approved these changes
Feb 1, 2021
lambdai
previously approved these changes
Feb 1, 2021
Contributor
lambdai
left a comment
There was a problem hiding this comment.
Thanks! I find the critical listener update in the integration test.
Signed-off-by: pengg <pengg@google.com>
ggreenway
approved these changes
Feb 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: pengg pengg@google.com
Commit Message: Fix a heap-use-after-free in LDS
Additional Description: ListenSocketFactoryImpl stores a const std::string& to the first Listener, which is destructed upon LDS update. When reuse_port is enabled, ListenSocketFactoryImpl reads the stale reference which may be a huge garbage string depending on where std::string::size() is aligned to the garbage memory region.
Risk Level: Low
Testing: Integration with ASAN to reproduce
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: