backport to 1.13: Fixes grpc tests on Windows (#12433)#14594
Merged
alyssawilk merged 1 commit intoenvoyproxy:release/v1.13from Jan 7, 2021
Merged
backport to 1.13: Fixes grpc tests on Windows (#12433)#14594alyssawilk merged 1 commit intoenvoyproxy:release/v1.13from
alyssawilk merged 1 commit intoenvoyproxy:release/v1.13from
Conversation
1. Adds localhost to the upstreamcert.cfg 2. Makes fake_upstream TcpListenerSocket connect to the localhost instead of any address. 3. GRPC tests are no longer failing on windows. Risk Level: Low Testing: N/A Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com> Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
alyssawilk
approved these changes
Jan 7, 2021
Contributor
alyssawilk
left a comment
There was a problem hiding this comment.
LGTM! feel free to ping me when CI finishes :-)
Contributor
Author
|
@alyssawilk CI is happy :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk Level: Low
Testing: N/A
Signed-off-by: Sotiris Nanopoulos sonanopo@microsoft.com
Signed-off-by: Christoph Pakulski christoph@tetrate.io