Skip to content

test: Add coverage on checking IP version when the local address is null #14528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattklein123 merged 3 commits into from
Dec 29, 2020
+8 −0
Merged

test: Add coverage on checking IP version when the local address is null #14528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67dee51
test: Add coverage on checking IP version when local address is null
dio Dec 28, 2020
49259e5
Nit
dio Dec 29, 2020
9287162
Test changing log level
dio Dec 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions test/common/network/listen_socket_impl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,11 @@ TEST_P(ListenSocketImplTestTcp, SetLocalAddress) {
EXPECT_EQ(socket.localAddress(), address);
}

TEST_P(ListenSocketImplTestTcp, CheckIpVersionWithNullLocalAddress) {
TestListenSocket socket(Utility::getIpv4AnyAddress());
EXPECT_EQ(Address::IpVersion::v4, socket.ipVersion());
}

TEST_P(ListenSocketImplTestUdp, BindSpecificPort) { testBindSpecificPort(); }

// Validate that we get port allocation when binding to port zero.
Expand Down
3 changes: 3 additions & 0 deletions test/extensions/common/wasm/wasm_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,9 @@ TEST_P(WasmCommonTest, Utilities) {
}

TEST_P(WasmCommonTest, Stats) {
// We set logger level to critical here to gain more coverage.
Logger::Registry::getLog(Logger::Id::wasm).set_level(spdlog::level::critical);

Stats::IsolatedStoreImpl stats_store;
Api::ApiPtr api = Api::createApiForTest(stats_store);
Upstream::MockClusterManager cluster_manager;
Expand Down