Replace rapidjson with nlohmann/json#14467
Merged
mattklein123 merged 25 commits intoenvoyproxy:mainfrom Feb 14, 2021
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Replace rapidjson with nlohmann/json
Additional Description:
envoy.reloadable_features.remove_legacy_json. It is disabled by default. I will enable the new parser in a separate PR.envoy/source/common/router/header_formatter.cc
Line 61 in e073b32
json_internal.ccimplementations is the custom stream class (see json_loader.cc line 243-280. It has a reference to the handler to update line numbers)Risk Level: Low for core, maybe medium for those using JSON on the dataplane.
Release Notes: Added release notes about runtime feature
Testing:
json_loader_test.ccis parametrized over both runtime values.Fixes Remove RapidJSON from Envoy #4705