Skip to content

backport to v1.13: connection: Remember transport socket read resumption requests and replay them when re-enabling read. (#13772) (#14173)#14255

Merged
antoniovicente merged 3 commits intoenvoyproxy:release/v1.13from
antoniovicente:ssl_resumption_v1.13
Dec 5, 2020
Merged

Conversation

@antoniovicente
Copy link
Copy Markdown
Contributor

Fixes SslSocket read resumption after readDisable when processing the SSL record that contains the last bytes of the HTTP message

…ion requests and replay them when re-enabling read. (envoyproxy#13772) (envoyproxy#14173)

Fixes SslSocket read resumption after readDisable when processing the SSL record that contains the last bytes of the HTTP message

Signed-off-by: Antonio Vicente <avd@google.com>
Signed-off-by: Antonio Vicente <avd@google.com>
Signed-off-by: Antonio Vicente <avd@google.com>
Copy link
Copy Markdown
Contributor

@cpakulski cpakulski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am wondering why clang_tidy was happy here, but failed in #14154 and changes are practically the same.

@antoniovicente
Copy link
Copy Markdown
Contributor Author

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #14255 (comment) was created by @antoniovicente.

see: more, trace.

@antoniovicente
Copy link
Copy Markdown
Contributor Author

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #14255 (comment) was created by @antoniovicente.

see: more, trace.

@antoniovicente antoniovicente merged commit 9584bcd into envoyproxy:release/v1.13 Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants