[fuzz] add back fuzzing build macro to CLI#14182
Merged
htuch merged 2 commits intoenvoyproxy:masterfrom Nov 25, 2020
Merged
Conversation
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
htuch
approved these changes
Nov 25, 2020
Member
htuch
left a comment
There was a problem hiding this comment.
LGTM, thanks! I think that eventually we want to figure out a way to get these configs out of router config_impl_test without running the test, i.e. just run the config phase. That's a nice-to-have-though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Asra Ali asraa@google.com
Commit Message: Adds back FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION macro to CLI.
This is the actual fix for #10322, after
nocoptswas a dead end from RE2 issue google/re2#272.Now when running real unit tests in fuzzing mode, we ignore the test result since we aren't testing for functionality. (
config_impl_testdoesn't need to succeed forroute_fuzz_testto build).Risk Level: Low
Testing: Testing fuzz mode fuzzers and regression style fuzzers locally