docs: Update start/install section#13490
Conversation
c040807 to
3fe85ab
Compare
|
after doing a bit of initial moving around i think it looks good: https://389760-65214191-gh.circle-artifacts.com/0/generated/docs/start/start.html im wondering about the https://389760-65214191-gh.circle-artifacts.com/0/generated/docs/start/ref_configs.html specifically, im wondering whether the sandboxes are kinda ref configs, and we should move the "Configuration generator" into tools |
72abce9 to
780edde
Compare
cf399d4 to
9f3aad4
Compare
Yeah I was going to discuss this with you. IMO we should merge configs/examples in the repo, and probably just move the config generator into examples? I think this would make more sense since what we have in configs at this point is really just another type of example. Is this ready for review or still WIP? |
still WIP im afraid - i have almost finished the install and docker pages:
so its worth having a look over them and the overall layout so far, but im still working on the rest |
|
im minded to land the "default configuration for docker" section as is for now and tidy up after (re #13497) |
i had thought to move it to tools - let me update and we can figure from there |
|
i see now - you mean move the actual ref configs to sandboxes - yep, i think thats a good idea. i had only started reading the "config generator" part, which i think can go to tools |
|
hmm, this is what the ref_configs point to https://390000-65214191-gh.circle-artifacts.com/0/generated/docs/intro/deployment_types/deployment_types.html i think we might want to look at the |
205aca6 to
02af108
Compare
|
@mattklein123 this is the last build on circleci https://390172-65214191-gh.circle-artifacts.com/0/generated/docs/start/start.html the probs worth looking over them as there are a lot of changes - trying to figure how i can add doc artifacts asap... (re #13506 ) |
mattklein123
left a comment
There was a problem hiding this comment.
Overall this is amazing! I love it. Left a few small comments. LMK when it's ready for full review.
/wait
|
@mattklein123 ive created a PR to deal with the Lyft references separately #13559 |
57bbd95 to
3e22cca
Compare
3e22cca to
7fd9a7a
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
|
Awesome, suggest we ship and iterate from here. Can you merge main? /wait |
2d7dcfa to
d5da910
Compare
|
cool, yep, just did, and fixing redirects |
|
@mattklein123 i think we need to wait for tests |
SG. Also, friendly request to please not force push. It makes reviews a lot more difficult. |
apologies, im more used to doing that to resolve confllicts. ill try to rem not to on a related not see #13735 |
|
aaggh - #13735 is causing master fail |
|
/retest |
|
Retrying Azure Pipelines. |
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: docs: Update start/install section
Additional Description:
This PR will
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue] Fix #13408 Fix #13491 touch #13461 touch #13439
[Optional Deprecated:]