Fix missing case of -Wrange-loop-analysis#13415
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Oct 7, 2020
Merged
Fix missing case of -Wrange-loop-analysis#13415mattklein123 merged 2 commits intoenvoyproxy:masterfrom
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
Conversation
Leftover from envoyproxy#13364. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
mattklein123
approved these changes
Oct 7, 2020
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thanks! Not sure how this passed upstream CI, I'm guessing different compiler version?
stevenzzzz
reviewed
May 30, 2024
| // instead of failing to route requests. | ||
| if (total_availability == 0) { | ||
| for (auto&& excluded_priority : excluded_priorities_) { | ||
| for (auto excluded_priority : excluded_priorities_) { |
Contributor
There was a problem hiding this comment.
is this for loop working as intended?
I think it's not reseting the status of the excluded_priorities_ before/after the change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leftover from #13364.
Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com