hcm: remove ContinueAndEndStream#13216
Merged
mattklein123 merged 11 commits intoenvoyproxy:masterfrom Oct 8, 2020
Merged
Conversation
added 6 commits
September 21, 2020 20:05
Instead of returning ContinueAndEndStream we can respond with a local reply. This removes the only use case of ContinueAndEndStream in non-test code. Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
With added support for sending local replies on the encoding path, this return value is no longer necessary. Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Contributor
Author
|
Blocked on #13205 |
added 4 commits
September 22, 2020 16:02
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Member
|
Putting this in waiting until we sort out the revert/re-apply. /wait |
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Signed-off-by: Snow Pettersen <snowp@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With added support for sending local replies on the encoding path, this
return value is no longer necessary.
Risk Level: Medium
Testing: Existing tests
Docs Changes: Updated the filter protocol doc
Release Notes: n/a