build: enable -Wrange-loop-analysis rule#13184
Closed
rebello95 wants to merge 5 commits intoenvoyproxy:masterfrom
Closed
build: enable -Wrange-loop-analysis rule#13184rebello95 wants to merge 5 commits intoenvoyproxy:masterfrom
rebello95 wants to merge 5 commits intoenvoyproxy:masterfrom
Conversation
Xcode 12 builds with this enabled, so adding this to Envoy will ensure compatibility and prevent breakages in Envoy Mobile's iOS build. Resolves envoyproxy#13140. Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Contributor
|
Looks like the build is failing because of the new option. |
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Contributor
Author
|
Looks like we are still getting errors from absl. Will probably need to wait until those are fixed upstream (or is there a way to only apply |
Member
|
It's not going to be easily possible for headers like this. I would recommend opening an abseil issue and linking it to the tracking issue and not setting it here project wide. |
Contributor
Author
|
Sounds good, I'll close this PR for now until abseil/abseil-cpp#787 is fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xcode 12 builds with this enabled, so adding this to Envoy will ensure compatibility and prevent breakages in Envoy Mobile's iOS build.
Resolves #13154.
Risk Level: Low
Testing: Existing unit tests
Signed-off-by: Michael Rebello me@michaelrebello.com