WIP router: introduce FilterManager#13095
Closed
snowp wants to merge 45 commits intoenvoyproxy:mainfrom
Closed
Conversation
added 15 commits
August 28, 2020 03:18
Refactor the ownership model of FM so that it can be composed more easily: by moving all ownership of headers to the HCM, nested FM can pass ownership all the way up. This simplifies ownership transfer complexities that arise when the FM attempts to own the headers. Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Contributor
Author
|
This is still far from complete but now passes test/integration:protocol_integration_test so at least its in somewhat the right shape. I'll start splitting out parts of this PR that makes sense so that it all can be reviewed independently. |
added 13 commits
September 15, 2020 15:41
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
added 5 commits
September 16, 2020 19:21
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Contributor
|
Just a thought, but once this stabilizes, could the changes to router land on their own, and we could copy-paste-clone the upstream request and runtime guard for a month or two? It is as you say a pretty high risk change. |
Contributor
Author
|
Yeah I think that would be prudent, this introduces a whole lot of new code into the upstream request flow, so hard to know what might break. |
added 12 commits
October 8, 2020 18:58
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the UpstreamRequest to use FilterManager with a UpstreamRequestFilter to manage the upstream stream. This will open up for eventually supporting upstream filters that can process the upstream request/response.
Commit Message:
Additional Description:
Risk Level: HIGH
Testing: Existing tests
Docs Changes: n/a
Release Notes: n/a
Part of #10455