Skip to content

cleanup: fix order of log statements#13003

Merged
htuch merged 1 commit intoenvoyproxy:masterfrom
numerodix:cleanup-fix-log-output
Sep 8, 2020
Merged

cleanup: fix order of log statements#13003
htuch merged 1 commit intoenvoyproxy:masterfrom
numerodix:cleanup-fix-log-output

Conversation

@numerodix
Copy link
Copy Markdown
Contributor

@numerodix numerodix commented Sep 8, 2020

Commit Message: cleanup: fix order of log statements
Risk Level: Low
Testing: Manual testing & bazel test //test/extensions/filters/http/ext_authz/...
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Martin Matusiak numerodix@gmail.com

@numerodix
cleanup: fix order of log statements
0a58163 
Signed-off-by: Martin Matusiak <numerodix@gmail.com>
@numerodix numerodix requested a review from dio as a code owner September 8, 2020 03:17
@numerodix
Copy link
Copy Markdown
Contributor Author

numerodix commented Sep 8, 2020

Before:

ext_authz filter added header(s) to the request:
ext_authz is clearing route cache
'x-authz-daemon-msg-to-upstream':'hi, this is the authz daemon!'

After:

ext_authz is clearing route cache
ext_authz filter added header(s) to the request:
'x-authz-daemon-msg-to-upstream':'hi, this is the authz daemon!'

htuch
htuch approved these changes Sep 8, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit 66bd20a into envoyproxy:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dio dio Awaiting requested review from dio

1 more reviewer

@htuch htuch htuch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@numerodix @htuch