Skip to content

coverage: increase dynamic forward proxy filter coverage#12971

Merged
junr03 merged 2 commits intoenvoyproxy:masterfrom
junr03:dynamic-forward-proxy-coverage
Sep 3, 2020
Merged

coverage: increase dynamic forward proxy filter coverage#12971
junr03 merged 2 commits intoenvoyproxy:masterfrom
junr03:dynamic-forward-proxy-coverage

Conversation

@junr03
Copy link
Copy Markdown
Member

@junr03 junr03 commented Sep 3, 2020

Commit Message: increase dynamic forward proxy coverage.
Additional Description: deletes the per file coverage bar
Risk Level: low
Testing: added tests

Signed-off-by: Jose Nino jnino@lyft.com

Signed-off-by: Jose Nino <jnino@lyft.com>
@junr03
Copy link
Copy Markdown
Member Author

junr03 commented Sep 3, 2020

running to see if this addition is sufficient to delete the lower per file bar.

Signed-off-by: Jose Nino <jnino@lyft.com>
@junr03
Copy link
Copy Markdown
Member Author

junr03 commented Sep 3, 2020

Nice, I get to delete another special case @alyssawilk :)

Copy link
Copy Markdown
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wohoo! LGTM!

@junr03 junr03 merged commit 2dfaf6e into envoyproxy:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants