accesslog: report on listener filter errors#12935
Merged
ggreenway merged 5 commits intoenvoyproxy:masterfrom Sep 3, 2020
Merged
accesslog: report on listener filter errors#12935ggreenway merged 5 commits intoenvoyproxy:masterfrom
ggreenway merged 5 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Contributor
Author
|
Not sure why ConnectionHandlerTest.RemoveListenerDuringRebalance fails on CI but passes locally with 1000 iterations |
ggreenway
reviewed
Sep 3, 2020
| EXPECT_CALL(dispatcher_, post(_)).WillOnce(SaveArg<0>(&post_cb)); | ||
| Network::MockConnectionSocket* connection = new NiceMock<Network::MockConnectionSocket>(); | ||
| current_handler->incNumConnections(); | ||
| #ifndef NDEBUG |
Contributor
Author
There was a problem hiding this comment.
There is #ifndef defined just below this. Honestly, I don't know why or why we have two variants of this test case.
Member
There was a problem hiding this comment.
Got it. Very strange, but the comment below, and linked comment in ~ActiveTcpListener, explain what's going on. This seems like it's not making anything worse then; just maintaining status quo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: emit logs in case listener filter reject or timeout incoming connections. Moved the stream info ownership to the active TCP socket. There are three cases that have to be handled separately: ownership transfer to TCP connection (how it works today), deferred deletion of TCP socket (via unlinking), direct deletion of TCP socket
Fixes: #12809
Risk Level: low
Testing: unit
Docs Changes: none
Release Notes: none