[fuzz] Split health_checker_impl_test for use in fuzzing#12908
Merged
asraa merged 6 commits intoenvoyproxy:masterfrom Sep 2, 2020
Merged
[fuzz] Split health_checker_impl_test for use in fuzzing#12908asraa merged 6 commits intoenvoyproxy:masterfrom
asraa merged 6 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Zach <zasweq@google.com>
Contributor
Author
|
/assign @asraa |
asraa
reviewed
Sep 1, 2020
Contributor
asraa
left a comment
There was a problem hiding this comment.
Thanks! Could you mention why not choose the production http health checker class?
Signed-off-by: Zach <zasweq@google.com>
Signed-off-by: Zach <zasweq@google.com>
Signed-off-by: Zach <zasweq@google.com>
Signed-off-by: Zach <zasweq@google.com>
asraa
reviewed
Sep 2, 2020
Contributor
asraa
left a comment
There was a problem hiding this comment.
Thanks! LGTM now. Thanks for cleaning up the dependencies for the util library.
Could you merge main to fix CI?
Contributor
Author
Merged! |
asraa
approved these changes
Sep 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Split health checker test for use in fuzzing
Additional Description: Using health checker test for fuzzing as code coverage shows > 90% line coverage over the health_checker_impl component. The health checker test classes expose a clean interface to call to get good coverage in the fuzzer.
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Zach Reyes zasweq@google.com