Note this issue in server_test at 197 and again at 216;

test/server/server_test.cc(197): note: Reason: cannot convert from 'const std::string_view' to 'const std::string'
test/server/server_test.cc(197): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
bazel-out/x64_windows-opt/bin/include/envoy/filesystem/_virtual_includes/filesystem_interface\envoy/filesystem/filesystem.h(93): note: see declaration of 'Envoy::Filesystem::Instance::fileExists'

I doubt there is a strong reason that fileExists() could not accept string_view

I doubt there is a strong reason that fileExists() could not accept string_view

I did not change the implementation because (i) all the function signatures in the filesystem interface take an std::string as input. Also (ii) the implementation of fileExists()relies on std::ifstream constructor. The constructor does not have an overload that accepts astring_view as input.

Also (ii) the implementation of fileExists()relies on std::ifstream constructor.

Thanks, now I recall tripping over this same puzzle before. I agree, explicitly creating temporary std::string(s) in test/server/server_test.cc should button up this commit, LGTM.

Please fix format.

/wait

what is the issue with #include "absl/strings/string_view.h" in platform.h, clang-tidy complains that the file is not found but this is the common way we include absl throughout the codebase.

I also tried to include it with #include <absl/strings/string_view.h> but then all the CI fails

Can you make sure the bazel build rule for the header includes a dep on string_view?

/wait