Adds PlatformDefaultTriggerType for FileTriggerType #12584
Merged
mattklein123 merged 5 commits intoenvoyproxy:masterfrom Aug 12, 2020
Merged
Adds PlatformDefaultTriggerType for FileTriggerType #12584mattklein123 merged 5 commits intoenvoyproxy:masterfrom
mattklein123 merged 5 commits intoenvoyproxy:masterfrom
Conversation
added 2 commits
August 10, 2020 15:49
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Member
Author
|
@envoyproxy/windows-dev |
nigriMSFT
reviewed
Aug 10, 2020
added 2 commits
August 10, 2020 16:56
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
lizan
approved these changes
Aug 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sotiris Nanopoulos sonanopo@microsoft.com
Adds
PlatformDefaultTriggerTypewhich is used to create file events. The main motivation for using this is the following:FileTriggerType. This is useful for UNIX devs to debug issues that might affect Windows.#ifdefs around the codebase.With this change,
proxy_protocol_testnow passes on Windows.Additional Description:
Risk Level: Low (No-Op, Most of the changes are calculated at compile time
Testing: N/A
Docs Changes: N/A
Release Notes: N/A