buffer impl: add cast for android compilation#12583
Merged
junr03 merged 1 commit intoenvoyproxy:masterfrom Aug 11, 2020
junr03:static-cast
Merged
buffer impl: add cast for android compilation#12583junr03 merged 1 commit intoenvoyproxy:masterfrom junr03:static-cast
junr03 merged 1 commit intoenvoyproxy:masterfrom
junr03:static-cast
Conversation
Signed-off-by: Jose Nino <jnino@lyft.com>
Member
Author
|
@roelfdutoit can you take a look? |
roelfdutoit
approved these changes
Aug 10, 2020
mattklein123
approved these changes
Aug 11, 2020
Contributor
|
Thanks for the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: add cast for android compilation
Additional Description: #12439 added a return value that had issues with implicit narrowing when building envoy mobile for android. This explicit cast fixes the build issues.
Risk Level: low using the expected type for the constructor as the static_cast type.
Testing: local build of envoy mobile for android. CI
Signed-off-by: Jose Nino jnino@lyft.com