fuzz: change expect_* to assert in xds_fuzz_test#12567
Merged
asraa merged 5 commits intoenvoyproxy:masterfrom Aug 12, 2020
Merged
fuzz: change expect_* to assert in xds_fuzz_test#12567asraa merged 5 commits intoenvoyproxy:masterfrom
asraa merged 5 commits intoenvoyproxy:masterfrom
Conversation
added 2 commits
August 6, 2020 12:29
Signed-off-by: Sam Flattery <samflattery@google.com>
Contributor
Author
|
/cc @asraa |
added 2 commits
August 10, 2020 14:10
Signed-off-by: Sam Flattery <samflattery@google.com>
Signed-off-by: Sam Flattery <samflattery@google.com>
Contributor
Author
|
@asraa forgot to change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Change expect_* to assert in xds_fuzz_test
Additional Description:
EXPECT_EQ/EXPECT_TRUEcalls cause errors to be logged but the fuzzer does not crash, meaning discrepancies do not show up on oss-fuzzupdateRoute()function from the verifier since it is redundantRisk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A