stats: Use dynamic stat-name for locality_zone_stat_name_ in upstream code. #11768
Merged
mattklein123 merged 7 commits intoenvoyproxy:masterfrom Jun 26, 2020
Merged
stats: Use dynamic stat-name for locality_zone_stat_name_ in upstream code. #11768mattklein123 merged 7 commits intoenvoyproxy:masterfrom
mattklein123 merged 7 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
mattklein123
approved these changes
Jun 26, 2020
Signed-off-by: Joshua Marantz <jmarantz@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: locality zones may not change much, but there's no great place to store symbolic StatNames for them. To avoid contention issues on the symbol table when processing EDS requests, make that a dynamic stat.
Additional Description:
Risk Level: low
Testing: //test/..., release-build //test/integration:stats_integration_test
Docs Changes: n/a
Release Notes: n/a
Fixes: #11573