ci: Fix macOS bazelisk symlink order issue#11181
Merged
lizan merged 1 commit intoenvoyproxy:masterfrom May 13, 2020
Merged
Conversation
In the case that the macOS image has the `bazel` formula symlinked to `/usr/local/bin/bazel` and bazelisk symlinked to `/usr/local/bin/bazelisk`, when you attempt to do the `brew link --overwrite` homebrew thinks bazelisk is already linked, even though the `bazel` link is wrong. By unlinking and relinking it, we force homebrew to actually overwrite `/usr/local/bin/bazel`. This appears to have started causing issues with a GitHub actions update this week. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Member
Author
|
The order of operations to get into the broken state on macOS is:
|
lizan
approved these changes
May 13, 2020
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case that the macOS image has the
bazelformula symlinked to/usr/local/bin/bazeland bazelisk symlinked to/usr/local/bin/bazelisk, when you attempt to do thebrew link --overwritehomebrew thinks bazelisk is already linked, even though thebazellink is wrong. By unlinking and relinking it, we force homebrewto actually overwrite
/usr/local/bin/bazel.This appears to have started causing issues with a GitHub actions update
this week.
Signed-off-by: Keith Smiley keithbsmiley@gmail.com