http: pausing when proxying CONNECT requests for security reasons#10974
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Apr 30, 2020
Merged
http: pausing when proxying CONNECT requests for security reasons#10974mattklein123 merged 3 commits intoenvoyproxy:masterfrom
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Closed
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
|
CI failure is integration:quic_http_integration_test |
mattklein123
requested changes
Apr 29, 2020
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thanks, LGTM with small comment.
/wait
Comment on lines
+397
to
+398
| const bool end_stream = !buffered_request_body_ && encode_complete_ && !encode_trailers_; | ||
| const bool delay_headers_end_stream = end_stream && !downstream_metadata_map_vector_.empty(); |
Member
There was a problem hiding this comment.
nit: this is pretty specific/confusing/copied from above. Small helper that returns a struct/tuple/something with comments that can be shared with above?
mattklein123
approved these changes
Apr 30, 2020
Member
mattklein123
left a comment
There was a problem hiding this comment.
Awesome, thanks for the last little cleanup, much easier to understand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk Level: Low (only affects CONNECT proxying, not yet used)
Testing: new unit tests, modified integration tests
Docs Changes: n/a
Release Notes: n/a
Part of #1630 #1451