Add TextReadout to Envoy::Stats::MetricSnapshot.#10961
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Apr 29, 2020
Merged
Add TextReadout to Envoy::Stats::MetricSnapshot.#10961mattklein123 merged 2 commits intoenvoyproxy:masterfrom
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Misha Efimov <mef@google.com>
Member
|
/azp rerun |
Member
|
/azp run envoy-presubmit |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jmarantz
reviewed
Apr 28, 2020
Contributor
jmarantz
left a comment
There was a problem hiding this comment.
code looks good; add unit-test to cover new stanza?
Contributor
|
/wait |
Signed-off-by: Misha Efimov <mef@google.com>
jmarantz
approved these changes
Apr 29, 2020
Contributor
|
@envoyproxy/senior-maintainers over to you |
ggreenway
approved these changes
Apr 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Add TextReadout to Envoy::Stats::MetricSnapshot.
Addresses TODO left in the initial PR.
Risk Level: low
Fixes #5790 @jmarantz