Skip to content

Draft: Information gathering/experimenting with Windows CI Workers#10610

Closed
sunjayBhatia wants to merge 11 commits intoenvoyproxy:masterfrom
greenhouse-org:testing-azp-windows-worker
Closed

Draft: Information gathering/experimenting with Windows CI Workers#10610
sunjayBhatia wants to merge 11 commits intoenvoyproxy:masterfrom
greenhouse-org:testing-azp-windows-worker

Conversation

@sunjayBhatia
Copy link
Copy Markdown
Member

Just a Draft PR to get some more info about the Windows CI workers in AZP to see if we can optimize the Windows job

sunjayBhatia and others added 3 commits April 1, 2020 11:15
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
@sunjayBhatia sunjayBhatia changed the title Information gathering/experimenting with Windows CI Workers Draft: Information gathering/experimenting with Windows CI Workers Apr 1, 2020
wrowe and others added 2 commits April 1, 2020 12:07
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
wrowe and others added 6 commits April 1, 2020 12:29
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
- replace WINDOWS_EXTENSIONS with very short WINDOWS_SKIP_TARGETS list
- fixes kafka compilation (MSVC parses the literal of INT32_MIN incorrectly)
- fixes luajit and moonjit compilation (only one jit is elected)
- extensions _SKIP_TARGET lists converted from dict to list
- compilation failures of the test packages are tagged skip_on_windows
- timeouts in failing packages are tagged fails_on_windows
- additional failing tests will be tagged in a subsequent commit

Flattened:

e6b5780c9 Remove erroneous test from PR #9964
2e9676f91 Temporary workaround to exclude WINDOWS_SKIP_TARGETS
6a463efc5 Shorten adaptive_concurrency/concurrency_controller path names
1a3e613da All but excluded tests now compile on Windows
977fb3557 Fix formatting and clean up test main invocation of WSAStartup
0e223b469 Windows CI steps ensures correct link.exe etc. on the PATH
fc7a292b5 Prepend VS tools to the path
1a2d3d863 Add a proper msys2 toolchain as recommended by Bazel
2ac269b88 Fix download path for msys2.tar.xz
8beaaa383 Fix tar path so it doesnt try to connect to a remote
1e28d37a0 Adjust tar change directory path
9827d57b2 Use unix style paths with tar only
de4f9c5bf msys2 has a subdir named msys64, put that properly on the PATH
e84133721 Redirect pacman stderr to stout
841ba43e7 Use bash for pacman.exe invocation
a47600a99 change cmd.exe invocation
5b14dfc8c Use bash to check existence, cmd.exe is not working
b398be57b See if MSYS2_ARG_CONV_EXCL helps
c1ded272c Strip msys64 out of extracted msys2 path
73408c9d7 Fix BAZEL_SH path
b7a6ca944 Fix path typo to find link.exe
727765ddd Cleanup unneeded content
25ac2fda9 Shrink bazel's java heap as suggested by Lizan

Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
@sunjayBhatia
Copy link
Copy Markdown
Member Author

this build did not fail https://dev.azure.com/cncf/envoy/_build/results?buildId=36568&view=logs&j=2d2b3007-3c5c-5840-9bb0-2b1ea49925f3&t=168f295b-0553-5364-35f7-923225ecd8b3 (just building a test that failed here due to cl heap size)

building this single test took over an hour, which is not promising

we can continue to experiment with optimizing this build, though I am also looking into getting Windows RBE to work since other projects seem to use that successfully (tensorflow, grpc)

@sunjayBhatia
Copy link
Copy Markdown
Member Author

Closing this as we're trying to get RBE working

@sunjayBhatia sunjayBhatia deleted the testing-azp-windows-worker branch April 21, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants