Merged
Conversation
Since the recent move to having protoxform emit active/next_major_version_candidate in preference to v2/v3, protoxform_test was broken. protoxform_test now runs on any CI involving proto changes, previously it was only triggered on failing CI runs involving proto changes. Risk level: Low Testing: protoxform_test.sh Signed-off-by: Harvey Tuch <htuch@google.com>
lizan
approved these changes
Mar 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the recent move to having protoxform emit
active/next_major_version_candidate in preference to v2/v3,
protoxform_test was broken.
protoxform_test now runs on any CI involving proto changes, previously
it was only triggered on failing CI runs involving proto changes.
Risk level: Low
Testing: protoxform_test.sh
Signed-off-by: Harvey Tuch htuch@google.com