listener: split listenerfilterfactorycontext and networkfilterfactorycontext#10491
listener: split listenerfilterfactorycontext and networkfilterfactorycontext#10491mattklein123 merged 73 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
mattklein123
left a comment
There was a problem hiding this comment.
Generally looks OK, thanks. Lets get the other PRs merged and the small comments addressed and than I think we can ship. Thank you!
/wait
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
|
merging master and resolving conflict with my other PR |
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
|
This is the closest situation to all check passing during these days. @mattklein123 I addressed all your comments. Could you take another (hopefully last) look? Thanks! |
| const Network::ConnectionSocket& socket) const; | ||
|
|
||
| const FilterChainManagerImpl* getOriginFilterChainManager() { | ||
| ASSERT(origin_.has_value()); |
There was a problem hiding this comment.
nit: This will throw an exception/crash on the following line so this ASSERT doesn't add any value. Please remove in your next change.
There was a problem hiding this comment.
I thought we prefer prefer these precondition-ish ASSERT since the assertion failure is more friendly in debugging mode.
Sure, I will update in the next PR. Thank you for allowing me amending in follow up!
| @@ -21,7 +21,7 @@ class FilterChainFactoryContextCreator { | |||
| * Generate the filter chain factory context from proto. Note the caller does not own the filter | |||
| * chain context. | |||
There was a problem hiding this comment.
Quick drive-by comment: IIUC, the caller does own the filter chain context now, is that right?
Description:
Extract from #9773
The ultimate goal is to update network filter chains without destructing all the network filter chains in previous listener config.
Splitting lifetime of listener filter and network filter, so that we can reuse the references to the existing listener filters in old listener (will do in follow up PR or see #9773)
The next PR is to arm the connection handler with in place filter chain update.
Also eliminate the risk of triggering warmed up listener when destroying ListenerImpl.
Risk Level: LOW since the life time is equivalent with and without this PR
Testing: Fixed existing tests
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]