tools: prevent use of 'throw new'#10116
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Feb 21, 2020
Merged
Conversation
Signed-off-by: Derek Argueta <darguetap@gmail.com>
Signed-off-by: Derek Argueta <darguetap@gmail.com>
asraa
reviewed
Feb 20, 2020
| // don't allow an empty configuration | ||
| if (!response_set_ && !request_set_) { | ||
| throw new EnvoyException("Must at least specify either response or request config"); | ||
| throw EnvoyException("Must at least specify either response or request config"); |
Contributor
There was a problem hiding this comment.
Love this! One of my fuzzers caught this but it's fixed in an open PR :) Anything to fix bugs with tools
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thanks this is great. Surprised that clang-tidy can't catch this. Is this ready for final review?
Member
Author
|
Should I remove the check_format.py change or leave a TODO? |
Member
|
I would probably just remove the format check and add it when you fix clang-tidy, but up to you. |
Signed-off-by: Derek Argueta <darguetap@gmail.com>
Member
Author
|
@mattklein123 SGTM, removed format check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
throw newshould be avoided, as the type being thrown is a pointer to the exception and not the exception itself. This can mess withcatchstatements. See https://stackoverflow.com/a/10964457 for more info.Risk Level: low
Testing: added
Docs Changes: n/a
Release Notes: n/a
Signed-off-by: Derek Argueta darguetap@gmail.com