Skip to content

route checker tool: add response headers#10090

Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
LisaLudique:headers
Feb 19, 2020
Merged

route checker tool: add response headers#10090
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
LisaLudique:headers

Conversation

@LisaLudique
Copy link
Copy Markdown
Contributor

Signed-off-by: Lisa Lu lisalu@lyft.com

Description: This change lets the route checker tool incorporate the proper response headers when doing route validation. It allows users to test how "response_headers_to_add" is configured in their route definitions.
Risk Level: Low
Testing: Unit testing
Docs Changes: N/A
Release Notes: N/A
Fixes #10072

Signed-off-by: Lisa Lu <lisalu@lyft.com>
@lizan lizan requested a review from mattklein123 February 19, 2020 00:23
@mattklein123 mattklein123 self-assigned this Feb 19, 2020
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit 43ef41d into envoyproxy:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

router_check_tool can't see response_headers_to_add

2 participants