-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Closed
Description
I had assumed that a filter should not expect to outlive the factory lambda that created it, so it should receive its config objects via a shared_ptr, e.g.:
And that's pretty much true for all filters, except for this one:
Is it OK then for filters to assume their creator will outlive them (and thus can we ditch shared_ptrs and pass refs instead)? Would be nice to have some consistency there (PRs to follow, if we agree).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels