-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Closed
Labels
Description
Title: curl is compiled without c-ares support and is prone to crashes on DNS timeouts due to longjmp.
Description: curl dependency (via cmake_external) was added as part of #5387 but does not use the already existing c-ares library for async DNS resolution and is prone to crashes on modern Linux kernels.
Suggested fix:
[Moved to a separate issue, irrelevant] change
curlfromcmake_externalto Bazel-native with a manually writtenBUILDfile like https://github.com/tensorflow/tensorflow/blob/master/third_party/curl.BUILD
- Add
deps = [//external:ares, //external:zlib]and-DUSE_ARES, -DHAVE_ZLIB_Hoptions
This will use Envoy's c-ares and zlib dependencies and instruct curl to use c-ares for DNS resolutions.
Reactions are currently unavailable