-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Closed
Labels
design proposalNeeds design doc/proposal before implementationNeeds design doc/proposal before implementationenhancementFeature requests. Not bugs or questions.Feature requests. Not bugs or questions.help wantedNeeds help!Needs help!
Description
Description:
I'd like to add a method to Envoy::OptionsImpl to specify a Bootstrap proto directly as opposed to using the setConfigYaml/setConfigPath fields, i.e. add something like:
void setConfigProto(const envoy::config::bootstrap::v2::Bootstrap& config_proto)This would allow clients to directly specify a Bootstrap proto object without having to deal with yaml serialization and would simplify our configuration process since we construct the Bootstrap proto programmatically as a protocol buffer.
Another option might be to have Envoy::OptionsImpl take a text proto, e.g. configTextProto.
While configPath does allow one to provide a text proto via the command line, I'd prefer a route that avoids the file system if possible.
Do any of these changes sound reasonable?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
design proposalNeeds design doc/proposal before implementationNeeds design doc/proposal before implementationenhancementFeature requests. Not bugs or questions.Feature requests. Not bugs or questions.help wantedNeeds help!Needs help!