Skip to content

Evaluate accesslog filters in Envoy rather than accesslog implementations #7325

@aunu53

Description

@aunu53

(Cleanup proposal.)

Currently, access log filters are manually evaluated in each implementation. Filters are instantiated and passed to the AccessLog::Instance, and then each AccessLog::Instance's log() implementation has logic of if (filter_ && filter_.evaluate(...)) then log(). Instead, I propose we move that logic up to some sort of public bool evaluate_filter(...) function in the AccessLog interface, and wrap all of Envoy's AccessLog::Instance::log() calls in a conditional.

cc: @ambuc @eziskind @AndresGuedez

Metadata

Metadata

Assignees

Labels

enhancementFeature requests. Not bugs or questions.help wantedNeeds help!

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions