-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Closed
Labels
stalestalebot believes this issue/PR has not been touched recentlystalebot believes this issue/PR has not been touched recentlytech debt
Milestone
Description
https://s3.amazonaws.com/lyft-envoy/coverage/report-master/coverage.html shows a bunch of relatively new functionality in stats lacks coverage. A common pattern is that due to multiple implementations of an API, we don't test-cover all cases.
Summarizing:
- histogram_impl.h: used() not called, 1 missing line
- isolated_store_impl.h: no coverage for findCounter(), findGauge, or findHistogram(). ~10 lines
- metric_impl.h: used() not called, 1 missing line
- scope_prefixer.h: 1 line, const symbolTable() accessor not called, 1 line.
- stat_data_allocator_impl.h: latch(), cacheSHouldImport(), setShouldImport() not called: 3 lines
- store_impl.h: counterFromStatName() etc not called: ~6 lines
- thread_local_store.h: const symbolTable() accessor not called. as well as not-found return-statement for findCounter() etc, 6 lines.
I'd like to suggest this division of labor:
@ahedberg can you do isolated_store_impl.h -- may want to outline the impls too?
@fredlas can you do stat_data_allocator_impl.h ?
I'll do the rest?
Reactions are currently unavailable