-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Closed
Labels
enhancementFeature requests. Not bugs or questions.Feature requests. Not bugs or questions.
Milestone
Description
Currently when the ca_cert_file is specified without verify_subject_alt_name or verify_certificate_hash in ssl_context, the SSL connection can still be successfully established when the peer does NOT present a certificate. This behavior may not be desirable as a peer without a valid cert and a peer with valid cert are treated equally and both can successfully establish a connection.
We should change it such that a peer must present a verifiable cert when ca_cert_file is set. With this change, the following cases can be supported:
- No
ca_cert_file: allow any peer - Only set
ca_cert_file: allow peers with valid certs ca_cert_fileandverify_certificate_hash: allow peers with valid certs of a particular hashca_cert_fileandverify_subject_alt_name: allow peers with valid certs and the SAN must match
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementFeature requests. Not bugs or questions.Feature requests. Not bugs or questions.