Skip to content

Explicit indication of shared_ptr in naming convention #583

@htuch

Description

@htuch

Can we switch to the following convention:

typedef std::unique_ptr<Foo> FooPtr;
typedef std::shared_ptr<Bar> BarSharedPtr;

across the code base? I'm finding it hard to review code with shared_ptr hidden under BarPtr (and read in general), as the shared ownership semantics are hidden.

If this sounds acceptable, I'm very happy to do an immediate PR to clean this up and document in the coding conventions.

@jamessynge @mattklein123

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions