-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Closed
Labels
design proposalNeeds design doc/proposal before implementationNeeds design doc/proposal before implementation
Description
Description:
Our project's logging requirements call for the direct connected host, i.e. the actual physical address on the other side of the downstream connection. The logging interface includes only request headers, response headers/trailers, and StreamInfo. StreamInfo.downstreamRemoteAddress() contains this information at first, but it's potentially modified by x-forwarded-for or a proxy proto.
A couple of proposals:
- Storing the downstream Network::Connection object in StreamInfo, which would be useful if anyone in the future needs information from the connection. Connection info could also be loggable via a change to the logging interface.
- Making the downstreamRemoteAddress behaviour configurable, i.e. a flag that will prevent it from being overwritten by proxy or forwarded-for info
- Adding another field to StreamInfo, e.g. downstreamDirectlyConnectedAddress
Thoughts? Opinions? Points of view?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
design proposalNeeds design doc/proposal before implementationNeeds design doc/proposal before implementation