-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Description
filterChainMatch: add support for source IPs and ports
Description:
There exist fields for this type of matching in the FilterHeadMatch proto already, they just have not been implemented. The implementation should be straightforward, as it should be very similar to the destination implementation.
As far as ordering @PiotrSikora and I were chatting, and believe that this should be added as the last matching criteria.
the idea behind putting it last is that then you still can do fancy selection of the destination, based on what’s available now and then do “horizon split” if you want to treat some clients differently.
Relevant to this issue is the fact that v1 tcp proxy filter supports source port and ips based routing, and in order for a v2 tcp proxy filter to support the same expressiveness we need the filter match criteria to support source based matching.