-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Closed
higress-group/envoy
#7Labels
area/golangenhancementFeature requests. Not bugs or questions.Feature requests. Not bugs or questions.
Description
Title: destroy go config explicitly using a callback to ensure go config lifecycle is bound to the C++ config lifecycle
Description:
Config created by a golang tcp or http filter can hold state or resources that need to be freed.
While it is technically possible to register the config object in gc finalizer, it breaks the idea of the config lifecycle in envoy.
The idea would be to introduce a Config interface with a Destroy function, and assert on the config type to call Destroy.
Let me know if that's something that you find useful.
I noticed that other golang plugins have different semantic regarding config and filter lifecycle. I was mainly focused on the http plugin.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area/golangenhancementFeature requests. Not bugs or questions.Feature requests. Not bugs or questions.