Skip to content

stats: when hot-restart is disabled, each stat still consumes maxNameLength() bytes for the name. #3508

@jmarantz

Description

@jmarantz

Description:

When storing stats in shared memory for hot-restart, we preallocate max_stats * maxNameLength for string storage. But this means you have to make hard up-front decisions about how much memory you can spend. However if we disable hot-restart, there's no compelling reason to pad each stat, so you could just set maxNameLength pretty high. If that were fixed, we wouldn't have to tune maxNameLength so carefully.

@ambuc may wind up looking at this as he was the last one to dive into the not-hot-restart case.

Metadata

Metadata

Assignees

Labels

enhancementFeature requests. Not bugs or questions.help wantedNeeds help!

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions