-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Closed
Labels
area/adminarea/perfenhancementFeature requests. Not bugs or questions.Feature requests. Not bugs or questions.no stalebotDisables stalebot from closing an issueDisables stalebot from closing an issue
Description
Currently the admin API is designed so the implementation must collect and return the entire response in one contiguous block. This means that very long responses such as /stats and /config_dump may introduce significant delay and memory pressure.
Specificallly:
envoy/source/exe/main_common.h
Line 52 in 7bd0c0f
| void adminRequest(absl::string_view path_and_query, absl::string_view method, |
Line 254 in 7bd0c0f
| virtual Http::Code request(absl::string_view path_and_query, absl::string_view method, |
These two interfaces should be changed so they allow for streaming. Note that we have a dependence on the current non-streaming versions so we might need to have both old and new versions at least temporarily.
This is related to #31082
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area/adminarea/perfenhancementFeature requests. Not bugs or questions.Feature requests. Not bugs or questions.no stalebotDisables stalebot from closing an issueDisables stalebot from closing an issue