Skip to content

Tag extraction rules missing for many stats #21595

@ggreenway

Description

@ggreenway

There are many stats for which default tag extraction rules should be written. The following list was generated from #21397.

For each match below, rules should be added to source/common/config/well_known_names.cc, and the TODO should be deleted.

The list was generated with grep -R -A 3 "TODO(ggreenway): add tag extraction rules." test/*.

  • test/extensions/filters/udp/dns_filter/dns_filter_integration_test.cc: // TODO(ggreenway): add tag extraction rules.
    test/extensions/filters/udp/dns_filter/dns_filter_integration_test.cc- // Missing stat tag-extraction rule for stat 'dns_filter.my_prefix.local_a_record_answers' and
    test/extensions/filters/udp/dns_filter/dns_filter_integration_test.cc- // stat_prefix 'my_prefix'.

  • test/extensions/filters/network/rbac/integration_test.cc: // TODO(ggreenway): add tag extraction rules.
    test/extensions/filters/network/rbac/integration_test.cc- // Missing stat tag-extraction rule for stat 'tcp.shadow_denied' and stat_prefix 'tcp.'.

  • test/extensions/filters/network/local_ratelimit/local_ratelimit_integration_test.cc: // TODO(ggreenway): add tag extraction rules.
    test/extensions/filters/network/local_ratelimit/local_ratelimit_integration_test.cc- // Missing stat tag-extraction rule for stat
    test/extensions/filters/network/local_ratelimit/local_ratelimit_integration_test.cc- // 'http_local_rate_limiter.http_local_rate_limit.rate_limited' and stat_prefix
    test/extensions/filters/network/local_ratelimit/local_ratelimit_integration_test.cc- // 'http_local_rate_limiter'.

  • test/extensions/filters/network/connection_limit/connection_limit_integration_test.cc: // TODO(ggreenway): add tag extraction rules.
    test/extensions/filters/network/connection_limit/connection_limit_integration_test.cc- // Missing stat tag-extraction rule for stat
    test/extensions/filters/network/connection_limit/connection_limit_integration_test.cc- // 'connection_limit.connection_limit_stats.limited_connections' and stat_prefix
    test/extensions/filters/network/connection_limit/connection_limit_integration_test.cc- // 'connection_limit_stats'.

  • test/extensions/filters/network/redis_proxy/redis_proxy_integration_test.cc: // TODO(ggreenway): add tag extraction rules.
    test/extensions/filters/network/redis_proxy/redis_proxy_integration_test.cc- // Missing stat tag-extraction rule for stat 'redis.redis_stats.command.ttl.error' and
    test/extensions/filters/network/redis_proxy/redis_proxy_integration_test.cc- // stat_prefix 'redis_stats'.

  • test/extensions/filters/http/local_ratelimit/local_ratelimit_integration_test.cc: // TODO(ggreenway): add tag extraction rules.
    test/extensions/filters/http/local_ratelimit/local_ratelimit_integration_test.cc- // Missing stat tag-extraction rule for stat
    test/extensions/filters/http/local_ratelimit/local_ratelimit_integration_test.cc- // 'http_local_rate_limiter.http_local_rate_limit.enabled' and stat_prefix
    test/extensions/filters/http/local_ratelimit/local_ratelimit_integration_test.cc- // 'http_local_rate_limiter'.

  • test/extensions/filters/http/ext_authz/ext_authz_integration_test.cc: // TODO(ggreenway): add tag extraction rules.
    test/extensions/filters/http/ext_authz/ext_authz_integration_test.cc- // Missing stat tag-extraction rule for stat 'http.ext_authz.failure_mode_allowed' and
    test/extensions/filters/http/ext_authz/ext_authz_integration_test.cc- // stat_prefix 'ext_authz'.

  • test/extensions/filters/http/ratelimit/ratelimit_integration_test.cc: // TODO(ggreenway): add tag extraction rules.

  • test/extensions/clusters/redis/redis_cluster_integration_test.cc: // TODO(ggreenway): add tag extraction rules.
    test/extensions/clusters/redis/redis_cluster_integration_test.cc- // Missing stat tag-extraction rule for stat 'redis.redis_stats.command.sadd.total' and
    test/extensions/clusters/redis/redis_cluster_integration_test.cc- // stat_prefix 'redis_stats'.

  • test/extensions/access_loggers/grpc/tcp_grpc_access_log_integration_test.cc: // TODO(ggreenway): add tag extraction rules.
    test/extensions/access_loggers/grpc/tcp_grpc_access_log_integration_test.cc- // Missing stat tag-extraction rule for stat 'grpc.accesslog.streams_closed_14' and stat_prefix
    test/extensions/access_loggers/grpc/tcp_grpc_access_log_integration_test.cc- // 'accesslog'.

  • test/extensions/access_loggers/grpc/http_grpc_access_log_integration_test.cc: // TODO(ggreenway): add tag extraction rules.
    test/extensions/access_loggers/grpc/http_grpc_access_log_integration_test.cc- // Missing stat tag-extraction rule for stat 'grpc.accesslog.streams_closed_11' and stat_prefix
    test/extensions/access_loggers/grpc/http_grpc_access_log_integration_test.cc- // 'accesslog'.

  • test/extensions/access_loggers/open_telemetry/access_log_integration_test.cc: // TODO(ggreenway): add tag extraction rules.
    test/extensions/access_loggers/open_telemetry/access_log_integration_test.cc- // Missing stat tag-extraction rule for stat 'grpc.accesslog.streams_closed_1' and stat_prefix
    test/extensions/access_loggers/open_telemetry/access_log_integration_test.cc- // 'accesslog'.

  • test/extensions/stats_sinks/metrics_service/metrics_service_integration_test.cc: // TODO(ggreenway): add tag extraction rules.
    test/extensions/stats_sinks/metrics_service/metrics_service_integration_test.cc- // Missing stat tag-extraction rule for stat 'grpc.metrics_service.streams_closed_14' and
    test/extensions/stats_sinks/metrics_service/metrics_service_integration_test.cc- // stat_prefix 'metrics_service'.

  • test/integration/scoped_rds.h: // TODO(ggreenway): add tag extraction rules.
    test/integration/scoped_rds.h- // Missing stat tag-extraction rule for stat
    test/integration/scoped_rds.h- // 'http.scoped_rds.foo-scoped-routes.grpc.srds_cluster.streams_closed_16' and stat_prefix
    test/integration/scoped_rds.h- // 'srds_cluster'.

  • test/integration/ads_integration_test.cc: // TODO(ggreenway): add tag extraction rules.
    test/integration/ads_integration_test.cc- // Missing stat tag-extraction rule for stat 'grpc.ads_cluster.streams_closed_13' and
    test/integration/ads_integration_test.cc- // stat_prefix 'ads_cluster'.

  • test/integration/ads_integration_test.cc: // TODO(ggreenway): add tag extraction rules.
    test/integration/ads_integration_test.cc- // Missing stat tag-extraction rule for stat 'grpc.ads_cluster.streams_closed_2' and stat_prefix
    test/integration/ads_integration_test.cc- // 'ads_cluster'.

  • test/integration/ads_integration_test.cc: // TODO(ggreenway): add tag extraction rules.
    test/integration/ads_integration_test.cc- // Missing stat tag-extraction rule for stat 'grpc.ads_cluster.streams_closed_2' and stat_prefix
    test/integration/ads_integration_test.cc- // 'ads_cluster'.

  • test/integration/listener_extension_discovery_integration_test.cc: // TODO(ggreenway): add tag extraction rules.
    test/integration/listener_extension_discovery_integration_test.cc- // Missing stat tag-extraction rule for stat
    test/integration/listener_extension_discovery_integration_test.cc- // 'extension_config_discovery.tcp_listener_filter.foo.grpc.ecds_cluster.streams_closed_7' and
    test/integration/listener_extension_discovery_integration_test.cc- // stat_prefix 'ecds_cluster'.

  • test/integration/sds_dynamic_integration_test.cc: // TODO(ggreenway): add tag extraction rules.
    test/integration/sds_dynamic_integration_test.cc- // Missing stat tag-extraction rule for stat
    test/integration/sds_dynamic_integration_test.cc- // 'sds.client_cert.grpc.sds_cluster.lyft.com.streams_closed_12' and stat_prefix
    test/integration/sds_dynamic_integration_test.cc- // 'sds_cluster.lyft.com'.

  • test/integration/sds_dynamic_integration_test.cc: // TODO(ggreenway): add tag extraction rules.
    test/integration/sds_dynamic_integration_test.cc- // Missing stat tag-extraction rule for stat
    test/integration/sds_dynamic_integration_test.cc- // 'sds.client_cert.grpc.sds_cluster.lyft.com.streams_closed_12' and stat_prefix
    test/integration/sds_dynamic_integration_test.cc- // 'sds_cluster.lyft.com'.

  • test/integration/ads_integration.cc: // TODO(ggreenway): add tag extraction rules.
    test/integration/ads_integration.cc- // Missing stat tag-extraction rule for stat 'grpc.ads_cluster.streams_closed_9' and stat_prefix
    test/integration/ads_integration.cc- // 'ads_cluster'.

  • test/integration/extension_discovery_integration_test.cc: // TODO(ggreenway): add tag extraction rules.
    test/integration/extension_discovery_integration_test.cc- // Missing stat tag-extraction rule for stat
    test/integration/extension_discovery_integration_test.cc- // 'listener_manager.lds.grpc.lds_cluster.streams_closed_10' and stat_prefix 'lds_cluster'.

  • test/integration/listener_lds_integration_test.cc: // TODO(ggreenway): add tag extraction rules.
    test/integration/listener_lds_integration_test.cc- // Missing stat tag-extraction rule for stat
    test/integration/listener_lds_integration_test.cc- // 'listener_manager.lds.grpc.lds_cluster.streams_closed_1' and stat_prefix 'lds_cluster'.

  • test/integration/listener_lds_integration_test.cc: // TODO(ggreenway): add tag extraction rules.
    test/integration/listener_lds_integration_test.cc- // Missing stat tag-extraction rule for stat
    test/integration/listener_lds_integration_test.cc- // 'listener_manager.lds.grpc.lds_cluster.streams_closed_1' and stat_prefix 'lds_cluster'.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions