-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Not showing deprecation warnings for boosted protos #17706
Copy link
Copy link
Closed
Labels
Milestone
Description
It turns out we still attempt to do API boosting in many cases, including bootstrap. This causes protos to load as v2, and once that happens, we miss out on important things like deprecation warnings as the field(s) are not deprecated in v2. This might also apply to PGV validation but I haven't checked that.
After discussing with @htuch we think it would be best to just remove boosting entirely. This might require fixing some tests along the way. If it turns out this is going to take a long time we could potentially:
- Change the default for do_boosting to false for all functions that support it and audit all prod code to make sure it stays false.
- Hardcode bootstrap version to 3 and fail if it's set to anything else. (We might still want to do this.)
Reactions are currently unavailable