Skip to content

Actually deprecate use_proxy_proto #17703

@mattklein123

Description

@mattklein123

google.protobuf.BoolValue use_proxy_proto = 4
[deprecated = true, (envoy.annotations.deprecated_at_minor_version) = "3.0"];

Has been deprecated for quite some time, but no warning or deprecation stat is emitted.

After the removal of tls inspector auto injection in #17373 this becomes particularly bad, because proxy proto now gets auto injected after manual listener filters which is almost definitely wrong.

We need to complete this deprecation first by warning on this field's use and emitting a deprecated stat, and then actually removing support for it entirely.

cc @ggreenway @tbarrella @lambdai

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions